From 17c3d19a9857d9bede3595f9e4e78207370d16ac Mon Sep 17 00:00:00 2001 From: fiatjaf Date: Tue, 5 Aug 2025 00:04:27 -0300 Subject: [PATCH] eventstore: remove useless sanity checking since event fields are already typed. --- eventstore/lmdb/replace.go | 6 ------ eventstore/lmdb/save.go | 6 ------ eventstore/mmm/replace.go | 6 ------ eventstore/mmm/save.go | 5 ----- 4 files changed, 23 deletions(-) diff --git a/eventstore/lmdb/replace.go b/eventstore/lmdb/replace.go index 2f2aed5..be8422d 100644 --- a/eventstore/lmdb/replace.go +++ b/eventstore/lmdb/replace.go @@ -3,7 +3,6 @@ package lmdb import ( "fmt" "iter" - "math" "fiatjaf.com/nostr" "fiatjaf.com/nostr/eventstore/internal" @@ -11,11 +10,6 @@ import ( ) func (b *LMDBBackend) ReplaceEvent(evt nostr.Event) error { - // sanity checking - if evt.CreatedAt > math.MaxUint32 || evt.Kind > math.MaxUint16 { - return fmt.Errorf("event with values out of expected boundaries %d/%d", evt.CreatedAt, evt.Kind) - } - return b.lmdbEnv.Update(func(txn *lmdb.Txn) error { filter := nostr.Filter{Limit: 1, Kinds: []nostr.Kind{evt.Kind}, Authors: []nostr.PubKey{evt.PubKey}} if evt.Kind.IsAddressable() { diff --git a/eventstore/lmdb/save.go b/eventstore/lmdb/save.go index fa6a646..f062b39 100644 --- a/eventstore/lmdb/save.go +++ b/eventstore/lmdb/save.go @@ -2,7 +2,6 @@ package lmdb import ( "fmt" - "math" "fiatjaf.com/nostr" "fiatjaf.com/nostr/eventstore" @@ -11,11 +10,6 @@ import ( ) func (b *LMDBBackend) SaveEvent(evt nostr.Event) error { - // sanity checking - if evt.CreatedAt > math.MaxUint32 || evt.Kind > math.MaxUint16 { - return fmt.Errorf("event with values out of expected boundaries %d/%d", evt.CreatedAt, evt.Kind) - } - return b.lmdbEnv.Update(func(txn *lmdb.Txn) error { if b.EnableHLLCacheFor != nil { // modify hyperloglog caches relative to this diff --git a/eventstore/mmm/replace.go b/eventstore/mmm/replace.go index 301a1f2..8fc78a4 100644 --- a/eventstore/mmm/replace.go +++ b/eventstore/mmm/replace.go @@ -3,7 +3,6 @@ package mmm import ( "fmt" "iter" - "math" "runtime" "fiatjaf.com/nostr" @@ -12,11 +11,6 @@ import ( ) func (il *IndexingLayer) ReplaceEvent(evt nostr.Event) error { - // sanity checking - if evt.CreatedAt > math.MaxUint32 || evt.Kind > math.MaxUint16 { - return fmt.Errorf("event with values out of expected boundaries") - } - il.mmmm.writeMutex.Lock() defer il.mmmm.writeMutex.Unlock() diff --git a/eventstore/mmm/save.go b/eventstore/mmm/save.go index cf8b3cd..5b67d97 100644 --- a/eventstore/mmm/save.go +++ b/eventstore/mmm/save.go @@ -53,11 +53,6 @@ func (b *MultiMmapManager) storeOn( iltxns []*lmdb.Txn, evt nostr.Event, ) (stored bool, err error) { - // sanity checking - if evt.CreatedAt > maxuint32 || evt.Kind > maxuint16 { - return false, fmt.Errorf("event with values out of expected boundaries") - } - // check if we already have this id val, err := mmmtxn.Get(b.indexId, evt.ID[0:8]) if err == nil {